This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
Ignore expected exceptions #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takhs91
changed the title
|
The feature this PR complements have been merged into dramatiq Bogdanp/dramatiq@7a1cba2 After it will get included in the next release this will be ready to merge |
|
I added a commit that also ignores Retry exceptions that were added Bogdanp/dramatiq@76525ad on that commit and they should be reported as an error |
|
Dramatiq released 1.9.0 with all matching changes. This can now be reviewed and merged |
|
Any updates? |
|
Hey @takhs91 - sorry for the long no ack time. I'm currently using dramatiq 1.11 and I have a few tasks that raise a Are these changes only for the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is complementary to a PR I opened to dramatiq Bogdanp/dramatiq#303 making the required changes in order to ignore exceptions that are part of the expected exceptions declared for an actor using a
throwsargument.This depends on my dramatiq PR so untill it gets reviewed, merged and released I open this as a draft