Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip colon from Ruby symbols #45

Merged
merged 1 commit into from
Jun 7, 2016
Merged

Strip colon from Ruby symbols #45

merged 1 commit into from
Jun 7, 2016

Conversation

wjlroe
Copy link
Contributor

@wjlroe wjlroe commented Jun 1, 2016

This means that a symbol :method_name will find the method even though
it's being referred to by a symbol.

This means that a symbol :method_name will find the method even though
it's being referred to by a symbol.
@wjlroe
Copy link
Contributor Author

wjlroe commented Jun 1, 2016

@jacktasia ah, yes, I just forgot to open a PR

@coveralls
Copy link

coveralls commented Jun 1, 2016

Coverage Status

Coverage decreased (-0.6%) to 99.39% when pulling 08a78c9 on wjlroe:strip-colon-from-ruby-symbols into 590773b on jacktasia:master.

@wjlroe
Copy link
Contributor Author

wjlroe commented Jun 1, 2016

I shall add some tests once I've gotten the tests to run on my machine

@jacktasia
Copy link
Owner

Awesome, thanks!

FWIW it should be as simple as making this test:

(ert-deftest dumb-jump-process-symbol-by-lang-test ()
  (let ((result (dumb-jump-process-symbol-by-lang "elisp" "somefunc"))
        (result2 (dumb-jump-process-symbol-by-lang "clojure" "myns/myfunc")))
    (should (string= result "somefunc"))
    (should (string= result2 "myfunc"))))

look like this instead:

(ert-deftest dumb-jump-process-symbol-by-lang-test ()
  (let ((result (dumb-jump-process-symbol-by-lang "elisp" "somefunc"))
        (result2 (dumb-jump-process-symbol-by-lang "clojure" "myns/myfunc"))
        (result3 (dumb-jump-process-symbol-by-lang "ruby" ":myrubyfunc")))
    (should (string= result "somefunc"))
    (should (string= result2 "myfunc"))
    (should (string= result3 "myrubyfunc"))))

@jacktasia jacktasia merged commit 1fcf595 into jacktasia:master Jun 7, 2016
jacktasia added a commit that referenced this pull request Jun 7, 2016
@wjlroe wjlroe deleted the strip-colon-from-ruby-symbols branch June 7, 2016 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants