Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to jump to modified buffers without confirmation #287

Merged

Conversation

codesections
Copy link
Contributor

Thanks for the dumb-jump—it's a great package and the simplicity really appeals to me. This is a PR for a patch that I find personally useful and thought others might as well.

It adds the option to jump directly to a buffer without being prompted for confirmation, even if that buffer is modified. I find that this is more often what I want, especially when jumping back up to the definition of a function defined earlier in the file (which, if I have been editing lower in the file, won't have moved at all).

Specifically, if the dumb-jump-confirm-jump-to-modified-file variable is nil, then jumping to a modified buffer will print a warning message but will not wait for confirmation.

I also revised the README to explain this additional option.

This commit adds the option to jump directly to a buffer without being
prompted for confirmation.  If the
`dumb-jump-confirm-jump-to-modified-file` variable is nil, then jumping
to a modified buffer will print a warning message but will not wait for
confirmation
@jacktasia jacktasia self-requested a review August 30, 2019 19:38
@jacktasia
Copy link
Owner

Thanks for opening this! I'll take a look after work today.

Copy link
Owner

@jacktasia jacktasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jacktasia jacktasia merged commit afa9df8 into jacktasia:master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants