Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support ruby namespaced classes, closes #243 #244

Merged
merged 1 commit into from
Nov 29, 2018
Merged

support ruby namespaced classes, closes #243 #244

merged 1 commit into from
Nov 29, 2018

Conversation

jacktasia
Copy link
Owner

@jacktasia jacktasia commented Nov 29, 2018 •
edited
Loading

@jacktasia
Copy link
Owner Author

@patbl This look correct to you?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 97.081% when pulling a61578e on issue-243 into b35b841 on master.

5 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 97.081% when pulling a61578e on issue-243 into b35b841 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 97.081% when pulling a61578e on issue-243 into b35b841 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 97.081% when pulling a61578e on issue-243 into b35b841 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 97.081% when pulling a61578e on issue-243 into b35b841 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 97.081% when pulling a61578e on issue-243 into b35b841 on master.

@patbl
Copy link
Contributor

patbl commented Nov 29, 2018

Yes, that looks good. Thanks so much!

@jacktasia jacktasia merged commit 720cf1f into master Nov 29, 2018
@jacktasia jacktasia deleted the issue-243 branch November 29, 2018 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacktasia @coveralls @patbl