Add basic support for jumping to functions in SQL files #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is incredibly basic, and adds support for syntax generally defined by the SQL standard, with provisions for syntax exposed by popular database engines, such as MySQL, PostgreSQL, MS-SQL etc. Both upper-case and lower-case definitions will match. A better solution would'be been to allow for case-insensitive matching, but mixed case within the same word should be rare enough to not be a problem at this stage.
|
Closes #27 |
|
I tried my hand at implementing support for variables, but the syntax is somewhat different between database engines (at least, the ones I'm familiar with). I'll look at implementing support for jumping to tables, views, and types, however. |
deuill
commented
May 27, 2018
| @@ -1036,6 +1036,14 @@ or most optimal searcher." | |||
| "functor test (T:TEST) =" | |||
| "functor test(T:TEST) =")) | |||
|
|
|||
| ;; sql | |||
| (:type "function" :supports ("ag" "grep" "rg" "git-grep") :language "sql" | |||
| :regex "(CREATE|create)\\s+(.+?\\s+)?(FUNCTION|function|PROCEDURE|procedure)\\s+JJJ\\s*\\\(" | |||
There was a problem hiding this comment.
I hate having to define the two variants, but couldn't find support for declaring the regex as case-insensitive. Perhaps adding an additional key for additional options to be passed to the command would do?
The syntax for these should be generic enough to match definitions for most popular database engines.
|
I've added support for tables, views, and types. Review away! |
|
This is awesome. Thanks so much for the PR! |
|
Thanks for building this awesome package ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is incredibly basic, and adds support for syntax generally defined by the SQL standard, with
provisions for syntax exposed by popular database engines, such as MySQL, PostgreSQL, MS-SQL etc.
Both upper-case and lower-case definitions will match. A better solution would'be been to allow for
case-insensitive matching, but mixed case within the same word should be rare enough to not be a
problem at this stage.