Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules for ruby #160

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Update rules for ruby #160

merged 1 commit into from
Sep 7, 2017

Conversation

knu
Copy link
Contributor

@knu knu commented Sep 6, 2017

  • Add support for mass assignment
  • Make rules stricter to reduce noises
  • Use \W intead of \j, since the latter does not seem to work well (namely with git-grep)

@coveralls
Copy link

coveralls commented Sep 6, 2017

Coverage Status

Coverage remained the same at 97.31% when pulling dff0612 on knu:update_rules_for_ruby into 3b4ab94 on jacktasia:master.

@knu
Copy link
Contributor Author

knu commented Sep 6, 2017

Another point: This adds support for git-grep, while removing use of (rather pointless) (?:...) which git-grep with -E given does not understand.

I think you could just use -P because almost all distributions of git has PCRE support compiled in including those of macOS and FreeBSD, not just Linux. However, that is another story.

@knu
Copy link
Contributor Author

knu commented Sep 6, 2017

Will fix the build failures.

@jacktasia
Copy link
Owner

Thanks for working on this! I'll merge it as soon as all the tests pass. Please let me know if I can help.

I think you could just use -P because almost all distributions of git has PCRE support compiled in including those of macOS and FreeBSD, not just Linux.

I can't remember now, but there was some OS/Distro back when I started this project where the default/built-in grep did not have support for -P. It might have been an older version macOS. That said, I am open to switching to using it I'd just need to do some tests and explicitly check if it -P is supported and then warn the user if it won't work.

@coveralls
Copy link

coveralls commented Sep 7, 2017

Coverage Status

Coverage remained the same at 97.31% when pulling f7008df on knu:update_rules_for_ruby into 3b4ab94 on jacktasia:master.

- Add support for git-grep
- Add support for mass assignment of variables
- Make rules stricter to reduce noises
- Use `\W` intead of `\j`, since the latter does not seem to work well
  (namely with git-grep)
@coveralls
Copy link

coveralls commented Sep 7, 2017

Coverage Status

Coverage remained the same at 97.31% when pulling e294eff on knu:update_rules_for_ruby into 3b4ab94 on jacktasia:master.

@jacktasia jacktasia merged commit 7df6460 into jacktasia:master Sep 7, 2017
@jacktasia
Copy link
Owner

Thanks!

@knu knu deleted the update_rules_for_ruby branch September 7, 2017 07:55
netromdk pushed a commit to netromdk/dumb-jump that referenced this pull request Dec 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants