Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lexical-bindings and emacs 24.3 #150

Closed
jacktasia opened this issue Jul 21, 2017 · 0 comments · Fixed by #152
Closed

lexical-bindings and emacs 24.3 #150

jacktasia opened this issue Jul 21, 2017 · 0 comments · Fixed by #152
Labels
help wanted

Comments

@jacktasia
Copy link
Owner

Using lexical-bindings seems to break tests for 24.3 as found via #149
@jacktasia jacktasia changed the title lexical-bindings and 24.3 lexical-bindings and emacs 24.3 Jul 21, 2017
akhramov pushed a commit to akhramov/dumb-jump that referenced this issue Jul 25, 2017
jacktasia#150 enable lexical bindings
d6f77f3 
It's been observed that tests fail on GNU Emacs 24.3 if lexical-bindings are
enabled. There could be various reasons for this, but most obvious is
that Emacs 24.3 had `byte-compile-add-to-list` function, which was used
as byte-compiled version of `add-to-list`:
emacs-mirror/emacs@0b31660#diff-38337c5e732c14fa599af4a0f6e53f18L4272

ert-runner compiles files before the test run, so tests used the
compiled version.

This commit rewrites functions that depended on add-to-list.
akhramov pushed a commit to akhramov/dumb-jump that referenced this issue Jul 25, 2017
jacktasia#150 enable lexical bindings
7acc874 
It's been observed that tests fail on GNU Emacs 24.3 if lexical-bindings are
enabled. There could be various reasons for this, but most obvious is
that Emacs 24.3 had `byte-compile-add-to-list` function, which was used
as byte-compiled version of `add-to-list`:
emacs-mirror/emacs@0b31660#diff-38337c5e732c14fa599af4a0f6e53f18L4272

ert-runner compiles files before the test run, so tests used the
compiled version.

This commit rewrites functions that depended on add-to-list.
@akhramov akhramov mentioned this issue Jul 25, 2017
Merged
jacktasia pushed a commit that referenced this issue Jul 26, 2017
@jacktasia
#150 enable lexical bindings (#152)
8fae9be 
It's been observed that tests fail on GNU Emacs 24.3 if lexical-bindings are
enabled. There could be various reasons for this, but most obvious is
that Emacs 24.3 had `byte-compile-add-to-list` function, which was used
as byte-compiled version of `add-to-list`:
emacs-mirror/emacs@0b31660#diff-38337c5e732c14fa599af4a0f6e53f18L4272

ert-runner compiles files before the test run, so tests used the
compiled version.

This commit rewrites functions that depended on add-to-list. Closes #150
netromdk pushed a commit to netromdk/dumb-jump that referenced this issue Dec 2, 2017
@netromdk
jacktasia#150 enable lexical bindings (jacktasia#152)
ee226ad 
It's been observed that tests fail on GNU Emacs 24.3 if lexical-bindings are
enabled. There could be various reasons for this, but most obvious is
that Emacs 24.3 had `byte-compile-add-to-list` function, which was used
as byte-compiled version of `add-to-list`:
emacs-mirror/emacs@0b31660#diff-38337c5e732c14fa599af4a0f6e53f18L4272

ert-runner compiles files before the test run, so tests used the
compiled version.

This commit rewrites functions that depended on add-to-list. Closes jacktasia#150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#150 enable lexical bindings akhramov/dumb-jump
1 participant
@jacktasia