A fix for the window disappearing immediately on iOS 13 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 21, 2019 11:46
…he window not opening on iOS 13.
davidfraser
approved these changes
Nov 21, 2019
There was a problem hiding this comment.
I think this is good for now. We're leaving out some of the code in the original pull request to deal with hidden browser windows, which we're not using. We've tested the times when we're hiding the window and it works fine.
In the long run we should try and get our changes upstream and not live on the fork, but it's good for now
thomascube
pushed a commit
to thomascube/cordova-plugin-inappbrowser
that referenced
this pull request
Jul 24, 2020
See j5int#10 issue #0008978
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of this pull request from the upstream repo. It's slightly modified, because some of the variables it referenced weren't present, and also having the call to
makeKeyAndVisibleconditional on the iOS version didn't work on iOS 13. It wouldn't show the window without it.I've tested this on all three devices, iPad 2, and both iPad minis, which I believe covers iOS 10, 12, and 13. I'm not sure if we have an iOS 11 device.