Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Email randomizer should not generate email addresses with valid domains. #265

Closed
chintebay opened this issue Aug 23, 2017 · 5 comments
Closed
Labels
Milestone

Comments

@chintebay
Copy link

I feel generating a real valid email address can led to actual issue some day (chance !)...maybe this should be generated with invalid email domains like h0tma1l.com or some such.

Apart from that, this looks great !

Best,
C

@PascalSchumacher
Copy link
Collaborator

Random-beans uses https://github.com/DiUS/java-faker to generate email addresses.

If you want more control over the generated email addresses you can use java-faker directly. For example new Faker().internet().safeEmailAddress() should generate a email address without a valid domain.

@fmbenhassine
Copy link
Member

Another option is to create a custom email randomizer that delegates domain name creation to a StringRandomizer. This will generate random domain names

@fmbenhassine
Copy link
Member

Another possibility is to add a parameter safe to the current EmailRandomizer to generate safe emails (delegating to faker's safeEmailAddress method).

@PascalSchumacher @chintebay What do you think?

@PascalSchumacher
Copy link
Collaborator

@PascalSchumacher @chintebay What do you think?

Sounds good imho.

@fmbenhassine
Copy link
Member

Hi @chintebay

Version 3.8.0-SNAPSHOT adds a boolean parameter called safe in the EmailRandomizer to generate safe emails (with invalid domain names).

Can you give it a try?

Kr
Mahmoud

@fmbenhassine fmbenhassine added this to the v3.8.0 milestone Sep 8, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants