Make random-beans build on java 9 #243

PascalSchumacher · 2017-02-26T16:37:24Z

First we need a java 9 compatible lombok version (see: projectlombok/lombok#1315), because currently on Java 9 Build 157 the build fails with:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project random-beans: Fatal error compiling: java.lang.ExceptionInInitializerError: Unable to make field private com.sun.tools.javac.processing.JavacProcessingEnvironment$DiscoveredProcessors com.sun.tools.javac.processing.JavacProcessingEnvironment.discoveredProcs accessible: module jdk.compiler does not "opens com.sun.tools.javac.processing" to unnamed module @90c01ab -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project random-beans: Fatal error compiling
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
        at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
        at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
        at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:547)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
        at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
        at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
        at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Fatal error compiling
        at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:954)
        at org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:137)
        at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
        at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
        ... 20 more
Caused by: org.codehaus.plexus.compiler.CompilerException: java.lang.ExceptionInInitializerError
        at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:173)
        at org.codehaus.plexus.compiler.javac.JavacCompiler.performCompile(JavacCompiler.java:174)
        at org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:943)
        ... 23 more
Caused by: java.lang.RuntimeException: java.lang.ExceptionInInitializerError
        at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:150)
        at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.doCall(JavacTaskImpl.java:100)
        at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.call(JavacTaskImpl.java:94)
        at org.codehaus.plexus.compiler.javac.JavaxToolsCompiler.compileInProcess(JavaxToolsCompiler.java:126)
        ... 25 more
Caused by: java.lang.ExceptionInInitializerError
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
        at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at java.base/java.lang.reflect.Constructor.newInstance(Constructor.java:473)
        at java.base/java.lang.Class.newInstance(Class.java:558)
        at lombok.core.AnnotationProcessor$JavacDescriptor.want(AnnotationProcessor.java:78)
        at lombok.core.AnnotationProcessor.init(AnnotationProcessor.java:140)
        at lombok.launch.AnnotationProcessorHider$AnnotationProcessor.init(AnnotationProcessor.java:69)
        at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$ProcessorState.<init>(JavacProcessingEnvironment.java:675)
        at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$DiscoveredProcessors$ProcessorStateIterator.next(JavacProcessingEnvironment.java:774)
        at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.discoverAndRunProcs(JavacProcessingEnvironment.java:869)
        at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.access$2200(JavacProcessingEnvironment.java:108)
        at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment$Round.run(JavacProcessingEnvironment.java:1204)
        at jdk.compiler/com.sun.tools.javac.processing.JavacProcessingEnvironment.doProcessing(JavacProcessingEnvironment.java:1313)
        at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.processAnnotations(JavaCompiler.java:1260)
        at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.compile(JavaCompiler.java:936)
        at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.lambda$doCall$0(JavacTaskImpl.java:104)
        at jdk.compiler/com.sun.tools.javac.api.JavacTaskImpl.handleExceptions(JavacTaskImpl.java:134)
        ... 28 more
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make field private com.sun.tools.javac.processing.JavacProcessingEnvironment$DiscoveredProcessors com.sun.tools.javac.processing.JavacProcessingEnvironment.discoveredProcs accessible: module jdk.compiler does not "opens com.sun.tools.javac.processing" to unnamed module @90c01ab
        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:335)
        at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:278)
        at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:175)
        at java.base/java.lang.reflect.Field.setAccessible(Field.java:169)
        at lombok.javac.apt.LombokProcessor.getFieldAccessor(LombokProcessor.java:109)
        at lombok.javac.apt.LombokProcessor.<clinit>(LombokProcessor.java:101)
        ... 46 more

The text was updated successfully, but these errors were encountered:

fmbenhassine · 2017-02-27T21:50:02Z

Oh great to see random beans on the road to be java 9 ready 😄

We can wait for lombok issue to be resolved. no hurry.

PascalSchumacher · 2017-02-27T22:04:05Z

Sure.

Did you take a look at reflection related changes in java 9? Java 9 forbids accessing private members from a different module. This is going to be a pain for random-bean users, because they will have to open up every package (e.g. --add-opens java.base/java.util=ALL-UNNAMED) for random-beans to access (as far as I know).

fmbenhassine · 2017-02-27T22:19:19Z

Yes, indeed. When moving to Java 9, we can profit from the major version v4.x to rewrite random beans using modules. It has been a long time that I would like to rewrite it from scratch..

PascalSchumacher · 2017-02-27T22:31:24Z

Yes that is a possibility, but if I'm not mistaken it will not change the fact, that it will be significantly harder for the user to start using random-beans on java 9. :(

fmbenhassine · 2017-02-28T07:34:44Z

if I'm not mistaken it will not change the fact

Yes yes, I should have added "By the way" after "Yes indeed". Rewriting random beans in modules does not change the fact that its users still have to open packages for introspection.

PascalSchumacher · 2017-03-22T21:58:07Z

According to http://mail.openjdk.java.net/pipermail/jigsaw-dev/2017-March/011763.html --permit-illegal-access in a future version of jdk9 will simplify granting access.

fmbenhassine · 2017-03-24T13:16:41Z

Thank you for the link, I saw it a couple of days ago on reddit.
Since this is a temporary switch, random beans users will have to explicitly grant access to their objects starting from Java 10. True strong encapsulation in Java starts with Java 10.

Anyway, this gives us some time (as libraries developers) to adapt random beans (if necessary) in v4 with Jdk 9.

- update lombok version to 1.16.16 - add java 9 maven profile which add java.xml.bind module for tests - fix two test which behave different on java 9 Random beans can now be build on java 9 with the right MAVEN_OPTS: --add-opens jdk.compiler/com.sun.tools.javac.processing=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.code=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.main=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.model=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.comp=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED --add-opens jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED

fmbenhassine added this to the 4.0.0 milestone Feb 28, 2017

fmbenhassine mentioned this issue Mar 26, 2017

Make random-beans 2.0.0 java6 compatible #248

Closed

PascalSchumacher closed this as completed in e1949d8 May 7, 2017

PascalSchumacher modified the milestones: 3.7.0, 4.0.0 May 7, 2017

fmbenhassine added the enhancement label Jun 18, 2017

fmbenhassine mentioned this issue Nov 8, 2017

Regression in Exception field generation in java 9 #280

Closed

fmbenhassine mentioned this issue Mar 9, 2020

Fix illegal reflective access operations on Java 9+ #385

Closed

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make random-beans build on java 9 #243

Make random-beans build on java 9 #243

PascalSchumacher commented Feb 26, 2017

fmbenhassine commented Feb 27, 2017

PascalSchumacher commented Feb 27, 2017 •

edited

Loading

fmbenhassine commented Feb 27, 2017

PascalSchumacher commented Feb 27, 2017

fmbenhassine commented Feb 28, 2017

PascalSchumacher commented Mar 22, 2017

fmbenhassine commented Mar 24, 2017 •

edited

Loading

Make random-beans build on java 9 #243

Make random-beans build on java 9 #243

Comments

PascalSchumacher commented Feb 26, 2017

fmbenhassine commented Feb 27, 2017

PascalSchumacher commented Feb 27, 2017 • edited Loading

fmbenhassine commented Feb 27, 2017

PascalSchumacher commented Feb 27, 2017

fmbenhassine commented Feb 28, 2017

PascalSchumacher commented Mar 22, 2017

fmbenhassine commented Mar 24, 2017 • edited Loading

PascalSchumacher commented Feb 27, 2017 •

edited

Loading

fmbenhassine commented Mar 24, 2017 •

edited

Loading