This repository has been archived by the owner on Mar 25, 2020. It is now read-only.
Only process incoming audio when listener attached #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only process incoming udpClient messages when a listener is attached to the 'incoming' event of the stream. This will address a possible performance issue when an audio context is obtained from the unnecessary creation of expensive objects. This is achieved by only attaching the message handler for the udpClient when a listener is attached to the 'incoming' event of the stream. It is no longer necessary to manually set whether or not to handle incoming audio; thus the option to do so is therefore removed. These changes do not make any breaking changes to the API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only process incoming udpClient messages when a listener is attached to the 'incoming' event of the stream. This will address a possible performance issue when an audio context is obtained from the unnecessary creation of expensive objects.
This is achieved by only attaching the message handler for the udpClient when a listener is attached to the 'incoming' event of the stream.
It is no longer necessary to manually set whether or not to handle incoming audio; thus the option to do so is therefore removed.
These changes do not make any breaking changes to the API.