Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use model_key for insert in strict mode and add initial_version_key #146

Merged
merged 2 commits into from
May 25, 2021

Conversation

ottobar
Copy link
Contributor

@ottobar ottobar commented May 12, 2021

The model key was hardcoded to :model in the strict mode branch of PaperTrail.Multi.insert/3 and was modified to use the model_key variable.

@ottobar ottobar changed the title Use model_key for insert in strict mode Use model_key for insert in strict mode and add initial_version_key May 12, 2021
@ottobar
Copy link
Contributor Author

ottobar commented May 12, 2021

Also realized that :initial_version was hardcoded, so added an option for that as well.

@izelnakri
Copy link
Owner

Hi @ottobar , looks like a nice contribution, thank you! I’ll pull, review and test this the next 2 days, meanwhile feel free to add yourself to the contributors :)

@izelnakri izelnakri merged commit 2c8f2d6 into izelnakri:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants