Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed numpy.ptp for all backends #28643

Merged
merged 1 commit into from
Mar 25, 2024
Merged

fix: fixed numpy.ptp for all backends #28643

merged 1 commit into from
Mar 25, 2024

Conversation

ZenithFlux
Copy link
Contributor

PR Description

  • added bool as unsupported dtype.
  • fixed dtype_values_axis unpacking in the test function.

Related Issue

Closes #28638
Closes #28639
Closes #28640
Closes #28641
Closes #28642

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

@ZenithFlux
fix: fixed issues with numpy.ptp
0922fd7 
added `bool` as unsupported dtype.
fixed `dtype_values_axis` unpacking.
@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Mar 19, 2024
Ishticode
Ishticode approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. Thank you @ZenithFlux for this :)

@Ishticode Ishticode merged commit 03a3912 into ivy-llc:main Mar 25, 2024
136 of 141 checks passed
@ZenithFlux ZenithFlux deleted the fixing_numpy_ptp branch March 27, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishticode Ishticode Ishticode approved these changes

Assignees

@Ishticode Ishticode

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
3 participants
@ZenithFlux @Ishticode @ivy-leaves