Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Frontend Failing Test: paddle - search.paddle.index_sample #28625

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

ZJay07
Copy link
Contributor

@ZJay07 ZJay07 commented Mar 17, 2024

PR Description

Screenshot 2024-03-17 at 18 28 59 Error was thrown because index and x are different dtypes

Related Issue

Close #28624

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Mar 17, 2024
Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good fix. Thanks for you continous efforts and fixes @ZJay07 :)

@Ishticode
Copy link
Contributor

Just one Note @ZJay07
In your opening comment the statement Closes #issue_number does not seem to link the issue it should be Close #... without the s. I will update the comment above to get the issue linked but something to keep in mind for future. Hope that helps :)

@Ishticode Ishticode merged commit 88581de into ivy-llc:main Mar 21, 2024
153 of 165 checks passed
@ZJay07
Copy link
Contributor Author

ZJay07 commented Mar 21, 2024

Oh sorry, didn't notice the signature is wrong, will change it for future PRs! Thanks for pointing this out

@ZJay07 ZJay07 deleted the fixing-test-12 branch March 21, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Frontend Failing Test: paddle - search.paddle.index_sample
3 participants