Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: for jax backend type hint, NativeArray shouldn't be a tuple #28543

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: for jax backend type hint, NativeArray shouldn't be a tuple #28543

merged 1 commit into from
Mar 12, 2024

Conversation

mattbarrett98
Copy link
Contributor

@mattbarrett98 mattbarrett98 commented Mar 11, 2024 •
edited
Loading

fix for NativeArray which was a tuple but this breaks things when it is used as a type hint. this fixes the issue for the jax readme demo

vedpatwardhan
vedpatwardhan approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@vedpatwardhan vedpatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Feel free to merge the PR, thanks @mattbarrett98 😄

@mattbarrett98 mattbarrett98 merged commit 65f695a into ivy-llc:main Mar 12, 2024
279 of 289 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedpatwardhan vedpatwardhan vedpatwardhan approved these changes

Assignees

@Ishticode Ishticode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattbarrett98 @vedpatwardhan @Ishticode