Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tensorflow Gather nd raw ops #28211

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

TalhaKhalil
Copy link
Contributor

PR Description

Related Issue

Closes #27443

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

@TalhaKhalil
Copy link
Contributor Author

Hi @vedpatwardhan

I have been working on this issue with @he11owthere and @NripeshN
All the test cases are passing on my local.

But while I was working with @he11owthere I had issues where some of the test cases passed and some didn't so he consulted me with the fix I've made in this PR.

Pls @vedpatwardhan look into this solution and let me know if there are any changes that needs to be made.

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Feb 7, 2024
@vedpatwardhan
Copy link
Contributor

Hey @TalhaKhalil, thanks for creating the PR, I'll leave this with @Ishticode to review as it's related to gather 😄

@TalhaKhalil
Copy link
Contributor Author

Hi @vedpatwardhan @Ishticode could you please provide me with any updates regarding the PR.

Copy link
Contributor

@Ishticode Ishticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @TalhaKhalil
Thank you very much for the PR. I have ran the tests locally with over 500 examples and they pass. I made a minor update to the function signature. Will merge now. Thanks for contributing :)

@Ishticode Ishticode merged commit 77ccffb into ivy-llc:main Feb 13, 2024
126 of 140 checks passed
@TalhaKhalil
Copy link
Contributor Author

Hi @Ishticode,
Thank you for your response, really appreciate it. And grateful for this opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GatherNd
6 participants