-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: skip tensorflow.zeros tests for Paddle backend with ndim >= 10 #23156
Conversation
Added a condition to skip tests in "test_tensorflow_zeros" when using the Paddle backend and the dimension is 10 or more. This is a temporary measure until the Paddle backend supports dimensions greater than 9.
Thanks for contributing to Ivy! 😊👏 |
Do tell if doing something like this would be better than the current solution! # zeros
@handle_frontend_test(
fn_tree="tensorflow.zeros",
input=helpers.get_shape(
allow_none=False,
min_num_dims=0,
max_num_dims=9,# CHANGE
min_dim_size=0,
max_dim_size=9, # CHANGE
),
dtype=helpers.get_dtypes("valid", full=False),
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @akshatvishu
I think the solution posed in the comment above might work better. The current solution does not fix the test as can be seen in the logs by searching for test_tensorflow_zeros,paddle
which still gives the error Invalid dimension to be accessed. Now only supports access to dimension 0 to 9, but received dimension is 10.
. Could you perhaps update and test. Thanks 🙂️
…t equal to 9 as PaddlePaddle only support till 9 dims.
Thanks for the suggestions @Ishticode , I have update the test code with the suggested changes! |
Thank you for this PR, here is the CI results: Failed tests:This PR introduces the following new failing tests: |
PR Description:
Added a condition to skip tests in "test_tensorflow_zeros" when using the Paddle backend and the dimension is 10 or more.
This is a temporary measure until the Paddle backend supports dimensions greater than 9.
Related Issue:
Close #23155