Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to abort RawImageLoader requests #583

Closed
frickt opened this issue Oct 11, 2018 · 2 comments
Closed

Unable to abort RawImageLoader requests #583

frickt opened this issue Oct 11, 2018 · 2 comments
Labels
bug Something isn't working
Milestone

Comments

@frickt
Copy link
Contributor

frickt commented Oct 11, 2018

the abort on RawImageLoader request does not work.
It's an issue with the UrlLoader.abort function, the readyState for these requests are UNSET and not LOADING as with DicomImageLoder.
As well the RawImageLoader.load function does not abort the image.onload async calls, so even after the abort, the images get rendered.

frickt added a commit to frickt/dwv that referenced this issue Oct 11, 2018
frickt added a commit to frickt/dwv that referenced this issue Oct 11, 2018
@ivmartel ivmartel added the bug Something isn't working label Oct 16, 2018
@ivmartel ivmartel added this to the 0.26.0 milestone Oct 16, 2018
ivmartel added a commit that referenced this issue Jan 18, 2019
…quests

Unable to abort RawImageLoader requests #583
@ivmartel ivmartel closed this as completed Mar 5, 2019
@Josecongas
Copy link

Hi @ivmartel , are you sure that this bug it's already fixed? I merge into my application the pull request #584 and it is not aborting the process for me. Thanks you in advance.

@ivmartel
Copy link
Owner

Hi @Josecongas, it is working for me: I try to load multiple pngs and cancel using crtl-x and the process gets cancelled. Now the images that have already been loaded still show, not sure if this is what you are expecting, the display could also be reset in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants