Clarify react-native dependency to be >=0.51.0, < 1.0.0 #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For 1.0.0 and above, caret means "matches major version", but for 0.x.0 and above, caret means "matches major and minor version". It's clear from usage that the intention for this dependency is to match the looser 1.0.0 caret usage. This change matches that, enabling explicit compatibility with react-native releases from the past 5 months. https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004 https://www.npmjs.com/package/react-native
|
Partially fixes #439 |
|
ping @Empact and maintainers, any love for this? Leaving warnings around unattended is creating a bad smell, mmkay :) |
|
Resolved merge conflicts |
|
Release is out. Thx for the reminder, @sesam ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For 1.0.0 and above, caret means "matches major version",
but for 0.x.0 and above, caret means "matches major and minor version".
It's clear from usage that the intention for this dependency is to
match the looser 1.0.0 caret usage. This change matches that, enabling
explicit compatibility with react-native releases from the past 5 months.
https://docs.npmjs.com/misc/semver#caret-ranges-123-025-004
https://www.npmjs.com/package/react-native