Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to specify word count #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bguiz
Copy link

@bguiz bguiz commented Aug 12, 2020

What

  • Current usage:
    • mnemonics
  • New usage:
    • mnemonics 15
    • (plus, current usage retained)
  • Input validation added

Why

  • Add ability for users to specify the number of words they would like in their mnemonic, instead of always using the default value

Note

  • The new functionality was put into src/utils.js, in anticipation of making it easier to write tests.
  • Given that there are currently no tests, I figured that adding them, and adding a test runner, would be something for a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant