Skip to content
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.

Make MLEM work with flyctl 0.1.x #678

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make MLEM work with flyctl 0.1.x #678

wants to merge 1 commit into from

Conversation

aguschin
Copy link
Contributor

close #677

@aguschin aguschin requested a review from a team as a code owner May 17, 2023 09:30
@aguschin aguschin self-assigned this May 17, 2023
@aguschin aguschin temporarily deployed to internal May 17, 2023 09:31 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 10.52% and project coverage change: -0.69 ⚠️

Comparison is base (5936765) 85.75% compared to head (46e803a) 85.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #678      +/-   ##
==========================================
- Coverage   85.75%   85.07%   -0.69%     
==========================================
  Files         109      109              
  Lines        9943     9954      +11     
==========================================
- Hits         8527     8468      -59     
- Misses       1416     1486      +70     
Impacted Files Coverage Δ
mlem/cli/deployment.py 87.50% <ø> (ø)
mlem/contrib/flyio/meta.py 43.80% <0.00%> (-1.50%) ⬇️
mlem/contrib/flyio/utils.py 48.33% <25.00%> (-2.62%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

cmd = run_flyctl("version --json", wrap_error=False)
output = json.loads(cmd.decode())
version = output.get("Version", None)
if not version or version.split(".")[1] != "1":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend using semver to parse and compare versions
here it would be:

version_str = output.get("Version", None)
if version_str is not None:
  version = semver.Version.parse(version_str)
  if ver.major < 1:
     ... 

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin flyctl version to <0.1.0 in MLEM
2 participants