This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
Workaround for dill IndexError #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With new sklearn version, some methods of custom class implementations are wrapped with some sklearn magic (see `sklearn.utils._SetOutputMixin`). This breaks `getsource` function from `dill.sources` which we use to get object source code. related uqfoundation/dill#581 closes #623
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
+ Coverage 84.43% 86.05% +1.62%
==========================================
Files 107 107
Lines 9733 9739 +6
==========================================
+ Hits 8218 8381 +163
+ Misses 1515 1358 -157
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
aguschin
approved these changes
Mar 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With new sklearn version, some methods of custom class implementations are wrapped with some sklearn magic (see
sklearn.utils._SetOutputMixin). This breaksgetsourcefunction fromdill.sourceswhich we use to get object source code.related uqfoundation/dill#581 closes #623