Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge gpu into dockerfile #179

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Merge gpu into dockerfile #179

merged 3 commits into from
Jul 27, 2020

Conversation

DavidGOrtega
Copy link
Contributor

This PR is for sake of simplicity in CML message, managing a fatter image VS easier to be explained and less confusing.
We still generate cml-gpu and cml-gpu-py3 for backward compatibility

@restyled-io restyled-io bot mentioned this pull request Jul 27, 2020
Merged
dmpetrov
dmpetrov approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@dmpetrov dmpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elleobrien
Copy link
Contributor

Looks awesome!

@elleobrien elleobrien merged commit 2e47d88 into master Jul 27, 2020
elleobrien added a commit that referenced this pull request Jul 27, 2020
@elleobrien
Update docker containers
d49e1ec 
in response to #179 and #159
@DavidGOrtega DavidGOrtega deleted the merge-gpu branch August 12, 2020 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmpetrov dmpetrov dmpetrov approved these changes

@elleobrien elleobrien elleobrien approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DavidGOrtega @elleobrien @dmpetrov @restyled-commits