Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options attribute to gem_package resource #186

Conversation

hico-horiuchi
Copy link
Contributor

Add options attribute to gem_package.
(This attribute is same as gem_package of Chef.)

For example:

gem_package 'bundler' do
  options ['--no-ri', '--no-rdoc']
end

@hico-horiuchi hico-horiuchi force-pushed the add-options-attribute-to-gem_package branch from dd46b87 to b21f2c1 Compare December 21, 2015 12:55
@@ -65,6 +65,10 @@
version '1.2.2'
end

gem_package 'bundler' do
options ['--no-ri', '--no-rdoc']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--no-ri and --no-rdoc are deprecated options. Please use --no-document

@hico-horiuchi
Copy link
Contributor Author

@ryotarai Installed ruby at test is 1.9.1 , so --no-document option is not supported.
Should I back the options to --no-ri --no-rdoc ?
Or would you update ruby to 2.0 and up?

DEBUG :       Executing `gem install --no-document bundler`...
DEBUG :         stdout | ERROR:  While executing gem ... (OptionParser::InvalidOption)
DEBUG :         stdout |     invalid option: --no-document

@ryotarai
Copy link
Member

Installed ruby at test is 1.9.1 , so --no-document option is not supported.
Should I back the options to --no-ri --no-rdoc ?

For now, using --no-ri --no-rdoc in tests is better.

@hico-horiuchi
Copy link
Contributor Author

I understand and remove the commit 8cc54c5 .

@hico-horiuchi hico-horiuchi force-pushed the add-options-attribute-to-gem_package branch from 8cc54c5 to b21f2c1 Compare December 28, 2015 08:56
@ryotarai
Copy link
Member

Thank you!

ryotarai added a commit that referenced this pull request Dec 30, 2015
…em_package

Add options attribute to gem_package resource
@ryotarai ryotarai merged commit 4cdd514 into itamae-kitchen:master Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants