Add "recursive" attribute to git resource #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great but I think the code is a little duplicated. How about the following? cmd = ['git', 'clone']
cmd << '--recursive' if attributes.recursive
cmd << attributes.repository << attributes.destination
run_command(cmd) |
|
Tests were failed, but I think it's not this change's sake. |
| @@ -29,7 +30,15 @@ def action_sync(options) | |||
| if run_specinfra(:check_file_is_directory, attributes.destination) | |||
| run_command_in_repo(['git', 'fetch', 'origin']) | |||
| else | |||
| run_command(['git', 'clone', attributes.repository, attributes.destination]) | |||
| if attributes.recursive | |||
There was a problem hiding this comment.
L33-37: Please remove these lines
|
That's my mistake... |
|
Thank you for your contribution! |
ryotarai
added a commit
that referenced
this pull request
Jul 6, 2015
Add "recursive" attribute to git resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose an new attribute "recursive" into git resource.
Example:
Then, "git clone --recursive https://github.com/foo/including_submodules.git" will be executed.