Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added perf test for 1.22 #15196

Merged
merged 31 commits into from
Jun 3, 2024
Merged

added perf test for 1.22 #15196

merged 31 commits into from
Jun 3, 2024

Conversation

Shuayb1
Copy link
Contributor

@Shuayb1 Shuayb1 commented May 29, 2024

Description

Reviewers

  • Ambient
  • [ X] Docs
  • Installation
  • Networking
  • [ X] Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

@Shuayb1 Shuayb1 requested a review from a team as a code owner May 29, 2024 19:09
@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 29, 2024
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label May 29, 2024
@ericvn ericvn added the cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch label May 30, 2024
@dhawton dhawton changed the title added per test for 1.22 added perf test for 1.22 May 30, 2024
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 30, 2024
craigbox
craigbox reviewed May 31, 2024
View reviewed changes
content/en/docs/ops/deployment/performance-and-scalability/istio-1.22.0-fortio-90.png Outdated Show resolved Hide resolved
content/en/docs/ops/deployment/performance-and-scalability/index.md Outdated Show resolved Hide resolved
content/en/docs/ops/deployment/performance-and-scalability/index.md Outdated Show resolved Hide resolved
content/en/docs/ops/deployment/performance-and-scalability/index.md Outdated Show resolved Hide resolved
content/en/docs/ops/deployment/performance-and-scalability/index.md Outdated Show resolved Hide resolved
content/en/docs/ops/deployment/performance-and-scalability/index.md Outdated Show resolved Hide resolved
content/en/docs/ops/deployment/performance-and-scalability/index.md Outdated Show resolved Hide resolved
content/en/docs/ops/deployment/performance-and-scalability/index.md Outdated Show resolved Hide resolved
Shuayb1 and others added 7 commits May 31, 2024 14:14
@Shuayb1 @craigbox
Update content/en/docs/ops/deployment/performance-and-scalability/ind…
90df668 
…ex.md

Co-authored-by: Craig Box <craig.box@gmail.com>
@Shuayb1 @craigbox
Update content/en/docs/ops/deployment/performance-and-scalability/ind…
5433f26 
…ex.md

Co-authored-by: Craig Box <craig.box@gmail.com>
@Shuayb1 @craigbox
Update content/en/docs/ops/deployment/performance-and-scalability/ind…
39b60f2 
…ex.md

Co-authored-by: Craig Box <craig.box@gmail.com>
@Shuayb1 @craigbox
Update content/en/docs/ops/deployment/performance-and-scalability/ind…
7ef49cf 
…ex.md

Co-authored-by: Craig Box <craig.box@gmail.com>
@Shuayb1 @craigbox
Update content/en/docs/ops/deployment/performance-and-scalability/ind…
b9dee50 
…ex.md

Co-authored-by: Craig Box <craig.box@gmail.com>
@Shuayb1 @craigbox
Update content/en/docs/ops/deployment/performance-and-scalability/ind…
b3a671d 
…ex.md

Co-authored-by: Craig Box <craig.box@gmail.com>
@Shuayb1
added perf test for 1.22
7380b04
linsun
linsun approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@linsun linsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the changes. @craigbox mentioned this page needs an overall update which can be a followup PR.

Not sure why the build failed, please check logs @Shuayb1!

@craigbox craigbox mentioned this pull request Jun 3, 2024
Open
craigbox
craigbox approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@craigbox craigbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for iterative improvement, with #15228 open for necessary followup:

  • update words to say ambient exists
  • add numbers
  • perhaps add something about testing methodology, and what exactly we're testing with these numbers.

@istio-testing istio-testing merged commit e6765a4 into istio:master Jun 3, 2024
6 checks passed
@istio-testing
Copy link
Contributor

In response to a cherrypick label: #15196 failed to apply on top of branch "release-1.22":

Applying: istio 1.20 performance result
Using index info to reconstruct a base tree...
M	content/en/docs/ops/deployment/performance-and-scalability/index.md
A	content/en/docs/ops/deployment/performance-and-scalability/latency_p90_fortio_with_jitter.svg
A	content/en/docs/ops/deployment/performance-and-scalability/latency_p99_fortio_with_jitter.svg
Falling back to patching base and 3-way merge...
Auto-merging content/en/docs/ops/deployment/performance-and-scalability/index.md
CONFLICT (content): Merge conflict in content/en/docs/ops/deployment/performance-and-scalability/index.md
CONFLICT (rename/delete): content/en/docs/ops/deployment/performance-and-scalability/latency_p99_fortio_with_jitter.svg deleted in istio 1.20 performance result and renamed to archive/v1.19/docs/ops/deployment/performance-and-scalability/latency_p99_fortio_with_jitter.svg in HEAD. Version HEAD of archive/v1.19/docs/ops/deployment/performance-and-scalability/latency_p99_fortio_with_jitter.svg left in tree.
CONFLICT (rename/delete): content/en/docs/ops/deployment/performance-and-scalability/latency_p90_fortio_with_jitter.svg deleted in istio 1.20 performance result and renamed to archive/v1.19/docs/ops/deployment/performance-and-scalability/latency_p90_fortio_with_jitter.svg in HEAD. Version HEAD of archive/v1.19/docs/ops/deployment/performance-and-scalability/latency_p90_fortio_with_jitter.svg left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 istio 1.20 performance result
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

@istio-testing
Copy link
Contributor

In response to a cherrypick label: new issue created for failed cherrypick: #15229

@istio-testing istio-testing mentioned this pull request Jun 3, 2024
Open
wilsonwu added a commit to wilsonwu/istio.io that referenced this pull request Jun 3, 2024
@wilsonwu
Sync istio#15196 update perf test for 1.22 into Chinese
ed3005a
@wilsonwu wilsonwu mentioned this pull request Jun 3, 2024
Merged
11 tasks
istio-testing pushed a commit that referenced this pull request Jun 3, 2024
@wilsonwu
Sync #15196 update perf test for 1.22 into Chinese (#15230)
eb342c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn left review comments

@dhawton dhawton dhawton left review comments

@ericvn ericvn ericvn left review comments

@craigbox craigbox craigbox approved these changes

@linsun linsun linsun approved these changes

Assignees
No one assigned
Labels
area/perf and scalability cherrypick/release-1.22 Set this label on a PR to auto-merge it to the release-1.22 branch kind/docs size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Shuayb1 @istio-testing @craigbox @howardjohn @dhawton @linsun @ericvn @istio-policy-bot