-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasm Configuration for Ambient Mode - Updates #15136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest-required
it is not ready for merge as he has mentioned in the description of the PR - test will pass only when the testing image is available with John's fix. i think it happens weekly once |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to remove the service specific waypoint proxy from the document. With the fix from @howardjohn it is not needed anymore. And then let us wait till the CI has the latest test image to retest this and see if it passes.
/retest |
1 similar comment
/retest |
/cherrypick release-1.22 |
@kfaseela: #15136 failed to apply on top of branch "release-1.22":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kfaseela: new issue created for failed cherrypick: #15166 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
* updated docs and test * revert go.mod * revert changes in go.mod * fixed lint error * Update snips.sh * removed service specific waypoint creation step * removed service specific waypoint creation step
This PR's modification addresses the resolution of an issue identified in Issue #51014 by John. Since the issue is fixed, we can now apply the WasmPlugin directly to the service instead of applying it to the gateway. Previously, despite providing credentials, requests to other services bypassed authentication, prompting the decision against applying the WasmPlugin directly to the service. Relevant tests have been updated to reflect these changes, although they will encounter failures until the new Istio image incorporating John's fixes is deployed.
Adds documentation as per : istio/istio#42337