Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasm Configuration for Ambient Mode - Updates #15136

Merged
merged 8 commits into from
May 21, 2024

Conversation

adilmp1
Copy link
Member

@adilmp1 adilmp1 commented May 16, 2024

This PR's modification addresses the resolution of an issue identified in Issue #51014 by John. Since the issue is fixed, we can now apply the WasmPlugin directly to the service instead of applying it to the gateway. Previously, despite providing credentials, requests to other services bypassed authentication, prompting the decision against applying the WasmPlugin directly to the service. Relevant tests have been updated to reflect these changes, although they will encounter failures until the new Istio image incorporating John's fixes is deployed.

Adds documentation as per : istio/istio#42337

@adilmp1 adilmp1 requested review from a team as code owners May 16, 2024 13:23
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 16, 2024
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2024
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2024
Copy link
Contributor

@craigbox craigbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest-required

@kfaseela
Copy link
Member

it is not ready for merge as he has mentioned in the description of the PR - test will pass only when the testing image is available with John's fix. i think it happens weekly once

Copy link
Member

@kfaseela kfaseela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to remove the service specific waypoint proxy from the document. With the fix from @howardjohn it is not needed anymore. And then let us wait till the CI has the latest test image to retest this and see if it passes.

go.mod Outdated Show resolved Hide resolved
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2024
@adilmp1 adilmp1 requested a review from kfaseela May 18, 2024 03:57
@kfaseela
Copy link
Member

/retest

1 similar comment
@kfaseela
Copy link
Member

/retest

@istio-testing istio-testing merged commit 3b533ac into istio:master May 21, 2024
12 checks passed
wilsonwu added a commit to wilsonwu/istio.io that referenced this pull request May 21, 2024
@kfaseela
Copy link
Member

/cherrypick release-1.22

@istio-testing
Copy link
Contributor

@kfaseela: #15136 failed to apply on top of branch "release-1.22":

Applying: updated docs and test
.git/rebase-apply/patch:19: trailing whitespace.
      group: ""                       
.git/rebase-apply/patch:36: trailing whitespace.
      group: ""                       
warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 updated docs and test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@istio-testing
Copy link
Contributor

@kfaseela: new issue created for failed cherrypick: #15166

In response to this:

/cherrypick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

adilmp1 added a commit to adilmp1/istio.io that referenced this pull request May 23, 2024
* updated docs and test

* revert go.mod

* revert changes in go.mod

* fixed lint error

* Update snips.sh

* removed service specific waypoint creation step

* removed service specific waypoint creation step
istio-testing pushed a commit that referenced this pull request Jun 27, 2024
* updated docs and test

* revert go.mod

* revert changes in go.mod

* fixed lint error

* Update snips.sh

* removed service specific waypoint creation step

* removed service specific waypoint creation step
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants