add interface for ignoring identity through command line #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aattuluri
requested changes
Dec 12, 2022
| @@ -0,0 +1,5 @@ | |||
| package clusters | |||
|
|
|||
| type EndpointSuspender interface { | |||
There was a problem hiding this comment.
Refactor this to EndpointUpdateSuspender?
There was a problem hiding this comment.
How about ServiceEntryUpdateSuspender ?
| if des.ignoredIdentityCache.EnvironmentsByIdentity[identity] != nil { | ||
| identityEnvironments := des.ignoredIdentityCache.EnvironmentsByIdentity[identity] | ||
| if len(identityEnvironments) == 0 || (len(identityEnvironments) == 1 && identityEnvironments[0] == "") { | ||
| log.Printf("%s, identity: %s", alertMsgSuspensionForIdentityInAllEnvironments, identity) |
There was a problem hiding this comment.
(len(identityEnvironments) == 1 && identityEnvironments[0] == "") is this a special case or just a safety check?
There was a problem hiding this comment.
Yes, this is the case when the entry is like:
identityByEnvironment: map[string][]string{
"identity": []string{""},
}
added 3 commits
December 12, 2022 11:09
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
Signed-off-by: Anubhav Aeron <anubhav_aeron@intuit.com>
nirvanagit
force-pushed
the
ignore-identity-interface
branch
from
c8c0048
to
5c19170
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Add interface for endpoint generation suspension so that other implementations can be easily swapped with the current command line implementation.