check deployment name before deleting deployment from cache #266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state
Given deployment cache has a valid deployment in its cache
And the deployment does not have an env annotation
And a debug deployment exists, without the env annotation
And debug deployment has the admiral.io/ignore annotation set to true,
And the env key is derived from namespace
When admiral receives an update event for the debug deployment, admiral calls this function
Then, the valid deployment is deleted because the deployment cache stores the deployment by key, which is the same for the valid deployment, as well as the debug deployment.
Change in PR
To prevent admiral from deleting the valid deployment, it will now match the deployment name it found in its cache, with the debug deployment (could be any deployment with ignore annotation, and same identity, and env (which can come from namespace)). The cache will be deleted only when the names match.