-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default connection pool parameters for generated cnames #257
Add default connection pool parameters for generated cnames #257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor typo change, looks good otherwise.
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 73.02% 73.10% +0.07%
==========================================
Files 31 31
Lines 3129 3138 +9
==========================================
+ Hits 2285 2294 +9
Misses 700 700
Partials 144 144
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com> Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
54a1d8d
to
c0bddbc
Compare
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This change adds a default HTTP connection pool configuration to the DestinationRule