Make remote controller access thread safe. #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvanagit
reviewed
Aug 1, 2022
admiral/pkg/clusters/types.go
Outdated
| ServiceEntryAddressStore: &ServiceEntryAddressStore{EntryAddresses: map[string]string{}, Addresses: []string{}}, | ||
| GlobalTrafficCache: gtpCache, | ||
| SeClusterCache: common.NewMapOfMaps(), | ||
|
|
nirvanagit
reviewed
Aug 1, 2022
| @@ -100,8 +100,8 @@ func TestAddServiceEntriesWithDr(t *testing.T) { | |||
| }, | |||
| } | |||
|
|
|||
| AddServiceEntriesWithDr(&admiralCache, map[string]string{"cl1": "cl1"}, map[string]*RemoteController{"cl1": rc}, map[string]*istionetworkingv1alpha3.ServiceEntry{"se1": &se}) | |||
| AddServiceEntriesWithDr(&admiralCache, map[string]string{"cl1": "cl1"}, map[string]*RemoteController{"cl1": rc}, map[string]*istionetworkingv1alpha3.ServiceEntry{"se1": &emptyEndpointSe}) | |||
| AddServiceEntriesWithDr(&RemoteRegistry{AdmiralCache: &admiralCache, remoteControllers: map[string]*RemoteController{"cl1": rc}}, map[string]string{"cl1": "cl1"}, map[string]*istionetworkingv1alpha3.ServiceEntry{"se1": &se}) | |||
There was a problem hiding this comment.
Should we use constructor (NewRemoteRegistry) here instead?
nirvanagit
reviewed
Aug 1, 2022
| @@ -62,7 +62,7 @@ func TestDeleteCacheControllerThatDoesntExist(t *testing.T) { | |||
| func TestDeleteCacheController(t *testing.T) { | |||
|
|
|||
| w := RemoteRegistry{ | |||
| RemoteControllers: make(map[string]*RemoteController), | |||
| remoteControllers: make(map[string]*RemoteController), | |||
There was a problem hiding this comment.
I think it will be useful to use the constructor (NewRemoteRegistry) everywhere, and make RemoteRegistry private.
There was a problem hiding this comment.
To make it private we will need an interface for RemoteRegistry.
nirvanagit
approved these changes
Aug 1, 2022
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
…io-ecosystem#147) * Make remote controller access thread safe. * Lint issue * Code review comments * More initializations fixed Co-authored-by: aattuluri <44482891+aattuluri@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.