Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force GTPs to update only #235

Merged

Conversation

shriramsharma
Copy link
Collaborator

Fixes: #234
force GTPs to update only

Signed-off-by: Shriram Sharma shriram_sharma@intuit.com

force GTPs to update only

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Copy link
Contributor

@aattuluri aattuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aattuluri aattuluri merged commit 3cd7ac8 into istio-ecosystem:master Jun 24, 2022
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
* Fixes: #234

force GTPs to update only

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>

* fixed linting errors

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
* Fixes: #234

force GTPs to update only

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>

* fixed linting errors

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>
Signed-off-by: sa <sushanth_a@intuit.com>
itsLucario pushed a commit to itsLucario/admiral that referenced this pull request Aug 9, 2022
…ystem#132)

* Fixes: istio-ecosystem#234

force GTPs to update only

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>

* fixed linting errors

Signed-off-by: Shriram Sharma <shriram_sharma@intuit.com>

Co-authored-by: aattuluri <AnilKumar_Attuluri@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Deleting a GTP would result in deleting the only endpoint of a service
2 participants