-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prom counters #211
Merged
Merged
Prom counters #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adilfulara
commented
May 3, 2022
•
edited
Loading
edited
- Add counter support.
- Add support for labels to metrics.
- Move metrics into common package and global scope.
- Add MonitoredDelegator to capture event metrics.
- add counter. rework tests - add support for labels - move metrics to metrics.go - update metrics tests with labels - use a dedicated delegator to capture metrics - renamed to MonitoredDelegator Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
Example of output from metrics endpoint with 3 cluster setup
Notice the |
lgtm |
aattuluri
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
* Prometheus Counters - add counter. rework tests - add support for labels - move metrics to metrics.go - update metrics tests with labels - use a dedicated delegator to capture metrics - renamed to MonitoredDelegator Signed-off-by: Adil Fulara <adil.fulara@gmail.com> Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
* Prometheus Counters - add counter. rework tests - add support for labels - move metrics to metrics.go - update metrics tests with labels - use a dedicated delegator to capture metrics - renamed to MonitoredDelegator Signed-off-by: Adil Fulara <adil.fulara@gmail.com> Signed-off-by: sa <sushanth_a@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
* Prometheus Counters - add counter. rework tests - add support for labels - move metrics to metrics.go - update metrics tests with labels - use a dedicated delegator to capture metrics - renamed to MonitoredDelegator Signed-off-by: Adil Fulara <adil.fulara@gmail.com> Signed-off-by: sa <sushanth_a@intuit.com>
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
…osystem#124) * Prometheus Counters - add counter. rework tests - add support for labels - move metrics to metrics.go - update metrics tests with labels - use a dedicated delegator to capture metrics - renamed to MonitoredDelegator Signed-off-by: Adil Fulara <adil.fulara@gmail.com> Signed-off-by: Adil Fulara <adil_fulara@intuit.com> Co-authored-by: Adil Fulara <adil.fulara@gmail.com>
itsLucario
pushed a commit
to itsLucario/admiral
that referenced
this pull request
Aug 9, 2022
…stio-ecosystem#124)" This reverts commit ca731ff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.