Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prometheus metric for number of clusters monitored #208

Merged
merged 14 commits into from
Apr 28, 2022
Merged

Add Prometheus metric for number of clusters monitored #208

merged 14 commits into from
Apr 28, 2022

Conversation

adilfulara
Copy link
Collaborator

Objective

  • Prometheus integration
    • exposed on port 6900
  • Gauge for clusters monitored by Admiral
    • metric name is: clusters_monitored

@adilfulara adilfulara marked this pull request as draft April 27, 2022 17:48
@adilfulara adilfulara marked this pull request as ready for review April 27, 2022 19:09
aattuluri
aattuluri requested changes Apr 27, 2022
View reviewed changes
admiral/cmd/admiral/cmd/root.go Outdated Show resolved Hide resolved
admiral/cmd/admiral/cmd/root.go Outdated Show resolved Hide resolved
admiral/pkg/controller/secret/secretcontroller.go Show resolved Hide resolved
@adilfulara
add promhttp. add /metrics endpoint. add basic handler test
280a757 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
switch to guage. add unit test to verify guage value is updated corre…
79b4fe9 
…ctly

Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
Separate out the metrics routes on an isolated mux server running on …
1109c6d 
…port 6900

Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
fix typo
57466b0 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
move metric creation to common
2b872c5 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
Switch from prom default registry to newly created regisry
2558d04 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
Use metrics pkg as a thin layer. Implement bool flag for enablement
975b282 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
cleanup
dedb2a8 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
remove incorrect test
068034d 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
rewrite metrics test case with correct func
9fc6650 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
move string constant to metric file
e00520d 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
rename to generic metrics
98c4e19 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara
CR feedback
a1d0db6 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
aattuluri
aattuluri approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@aattuluri aattuluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aattuluri aattuluri changed the title Prometheus Integration Add Prometheus metric for number of clusters monitored Apr 28, 2022
@adilfulara
add dependency to fix build
fd0a84c 
Signed-off-by: Adil Fulara <adil.fulara@gmail.com>
@adilfulara adilfulara merged commit 72d5ec4 into istio-ecosystem:master Apr 28, 2022
@adilfulara adilfulara deleted the prom-init branch April 28, 2022 18:10
psikka1 pushed a commit to psikka1/admiral that referenced this pull request Jun 14, 2022
@adilfulara @psikka1
Add Prometheus metric for number of clusters monitored (istio-ecosyst…
3cc793a 
…em#208)

- Add cli flag to enable metrics collection via prometheus.
- Add endpoint to expose metrics in prometheus format when enabled and noop when disabled.
- Add gauge to capture clusters monitored metric.
psikka1 pushed a commit to psikka1/admiral that referenced this pull request Jun 15, 2022
@adilfulara @psikka1
Add Prometheus metric for number of clusters monitored (istio-ecosyst…
df45358 
…em#208)

- Add cli flag to enable metrics collection via prometheus.
- Add endpoint to expose metrics in prometheus format when enabled and noop when disabled.
- Add gauge to capture clusters monitored metric.

Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk pushed a commit that referenced this pull request Jul 21, 2022
@adilfulara
Add Prometheus metric for number of clusters monitored (#208)
ae38c8b 
- Add cli flag to enable metrics collection via prometheus.
- Add endpoint to expose metrics in prometheus format when enabled and noop when disabled.
- Add gauge to capture clusters monitored metric.

Signed-off-by: sa <sushanth_a@intuit.com>
itsLucario pushed a commit to itsLucario/admiral that referenced this pull request Aug 9, 2022
@adilfulara
GED-202204 Add prometheus metrics for Admiral (istio-ecosystem#110)
89e074f 
* Add Prometheus metric for number of clusters monitored (istio-ecosystem#208)

- Add cli flag to enable metrics collection via prometheus.
- Add endpoint to expose metrics in prometheus format when enabled and noop when disabled.
- Add gauge to capture clusters monitored metric.

* Prometheus Install in demo cluster (istio-ecosystem#209)

- Add kustomize template to install prometheus for scraping metrics
- Update admiral kustomize template for scraping by prometheus
- Add install script for prometheus
- Update CONTRIBUTING doc

Signed-off-by: Adil Fulara <adil.fulara@gmail.com>

Co-authored-by: Adil Fulara <adil.fulara+github@gmail.com>
Co-authored-by: Adil Fulara <adil.fulara@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aattuluri aattuluri aattuluri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adilfulara @aattuluri