fix: weighted services for source #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2022 18:27
Signed-off-by: nbn01 <nandan_bn@intuit.com>
If the canary rollout present in both east and west Signed-off-by: nbn01 <nandan_bn@intuit.com>
aattuluri
approved these changes
Apr 14, 2022
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 14, 2022
* fix: local fqdn not updated within same cluster for bluegreen Signed-off-by: nbn01 <nandan_bn@intuit.com> * fix: wrong local FQDN updated for canary with weights If the canary rollout present in both east and west Signed-off-by: nbn01 <nandan_bn@intuit.com> Co-authored-by: nbn01 <nandan_bn@intuit.com>
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
* fix: local fqdn not updated within same cluster for bluegreen Signed-off-by: nbn01 <nandan_bn@intuit.com> * fix: wrong local FQDN updated for canary with weights If the canary rollout present in both east and west Signed-off-by: nbn01 <nandan_bn@intuit.com> Co-authored-by: nbn01 <nandan_bn@intuit.com> Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
* fix: local fqdn not updated within same cluster for bluegreen Signed-off-by: nbn01 <nandan_bn@intuit.com> * fix: wrong local FQDN updated for canary with weights If the canary rollout present in both east and west Signed-off-by: nbn01 <nandan_bn@intuit.com> Co-authored-by: nbn01 <nandan_bn@intuit.com> Signed-off-by: sa <sushanth_a@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weightedServiceswas initialized with K8s services without the source cluster context, which results in wrong weightedServices being used when the service existed in multiple cluster.The PR fixes the issue by initializing
sourceWeightedServiceswith source cluster as key and use it for endpoint's local FQDN.