-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for BlueGreen rollout preview endpoint #199
Support for BlueGreen rollout preview endpoint #199
Conversation
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
c36fb50
to
50c0ce5
Compare
Signed-off-by: nbn01 <nandan_bn@intuit.com>
Signed-off-by: nbn01 <nandan_bn@intuit.com>
5a2e8b7
to
c97ed13
Compare
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 74.42% 75.02% +0.60%
==========================================
Files 26 26
Lines 2530 2567 +37
==========================================
+ Hits 1883 1926 +43
+ Misses 516 512 -4
+ Partials 131 129 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, added a question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@itsLucario There are lint errors, fix them before we can merge. |
bac0a2b
to
c97ed13
Compare
Signed-off-by: nbn01 <nandan_bn@intuit.com>
golangci-lint was using go1.18 that caused the panic. I added a fix to the workflow to use go1.17.7. |
…m#199) * Changes to support preview endpoint for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated integration test for preview endpoint Signed-off-by: nbn01 <nandan_bn@intuit.com> * Minor check fixes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverted integration test changes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update unit tests Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add integration test for preview endpoint of bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update makefile Signed-off-by: nbn01 <nandan_bn@intuit.com> * Modified permissions Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverting argo_rollouts default to false Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated unit tests to check when preview service not defined Signed-off-by: nbn01 <nandan_bn@intuit.com> * Improved integration test for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Continue with normal flow if preview condition fails Signed-off-by: nbn01 <nandan_bn@intuit.com> * Uncomment clean up Signed-off-by: nbn01 <nandan_bn@intuit.com> * make "preview" standard prefix name for bluegreen Signed-off-by: nbn01 <nandan_bn@intuit.com> * abstract update preview endpoint to method Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add unit test Signed-off-by: nbn01 <nandan_bn@intuit.com> * fix golintci lint to use go1.17.7 Signed-off-by: nbn01 <nandan_bn@intuit.com> Co-authored-by: nbn01 <nandan_bn@intuit.com>
…m#199) * Changes to support preview endpoint for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated integration test for preview endpoint Signed-off-by: nbn01 <nandan_bn@intuit.com> * Minor check fixes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverted integration test changes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update unit tests Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add integration test for preview endpoint of bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update makefile Signed-off-by: nbn01 <nandan_bn@intuit.com> * Modified permissions Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverting argo_rollouts default to false Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated unit tests to check when preview service not defined Signed-off-by: nbn01 <nandan_bn@intuit.com> * Improved integration test for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Continue with normal flow if preview condition fails Signed-off-by: nbn01 <nandan_bn@intuit.com> * Uncomment clean up Signed-off-by: nbn01 <nandan_bn@intuit.com> * make "preview" standard prefix name for bluegreen Signed-off-by: nbn01 <nandan_bn@intuit.com> * abstract update preview endpoint to method Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add unit test Signed-off-by: nbn01 <nandan_bn@intuit.com> * fix golintci lint to use go1.17.7 Signed-off-by: nbn01 <nandan_bn@intuit.com> Co-authored-by: nbn01 <nandan_bn@intuit.com> Signed-off-by: psikka1 <pankaj_sikka@intuit.com>
* Changes to support preview endpoint for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated integration test for preview endpoint Signed-off-by: nbn01 <nandan_bn@intuit.com> * Minor check fixes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverted integration test changes Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update unit tests Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add integration test for preview endpoint of bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Update makefile Signed-off-by: nbn01 <nandan_bn@intuit.com> * Modified permissions Signed-off-by: nbn01 <nandan_bn@intuit.com> * Reverting argo_rollouts default to false Signed-off-by: nbn01 <nandan_bn@intuit.com> * Updated unit tests to check when preview service not defined Signed-off-by: nbn01 <nandan_bn@intuit.com> * Improved integration test for bluegreen rollout Signed-off-by: nbn01 <nandan_bn@intuit.com> * Continue with normal flow if preview condition fails Signed-off-by: nbn01 <nandan_bn@intuit.com> * Uncomment clean up Signed-off-by: nbn01 <nandan_bn@intuit.com> * make "preview" standard prefix name for bluegreen Signed-off-by: nbn01 <nandan_bn@intuit.com> * abstract update preview endpoint to method Signed-off-by: nbn01 <nandan_bn@intuit.com> * Add unit test Signed-off-by: nbn01 <nandan_bn@intuit.com> * fix golintci lint to use go1.17.7 Signed-off-by: nbn01 <nandan_bn@intuit.com> Co-authored-by: nbn01 <nandan_bn@intuit.com> Signed-off-by: sa <sushanth_a@intuit.com>
Currently when Admiral generates endpoint for Rollouts with bluegreen it always uses active/stable service as destination. This PR will adds a feature to generate an additional mesh endpoint that would point to the preview service of the blugreen stack.