feat: add a sources option allowing to bypass fs operations #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 136
💛 - Coveralls |
bcoe
approved these changes
Jun 23, 2019
bcoe
approved these changes
Jun 23, 2019
|
Definitely needs a test or two! I'll come back to it once we've settled on an API. This one feels a bit brute force. I think maybe some of this sourcemap logic could move to |
shinnn
reviewed
Jul 6, 2019
| // both the transpiled and original source, both of which are used during | ||
| // the backflips we perform to remap absolute to relative positions. | ||
| const rawSourceMap = convertSourceMap.fromSource(rawSource) || convertSourceMap.fromMapFileSource(rawSource, dirname(this.path)) | ||
| const rawSource = this.sources.source || readFileSync(this.path, 'utf8') |
There was a problem hiding this comment.
When this.sources.source is a zero-length string, it still tries to read an actual file. I guess you meant
this.sources.source === undefined ? readFileSync(this.path, 'utf8') : this.sources.sourceThere was a problem hiding this comment.
good call!
FWIW, I'm still not happy with the branching logic I introduced in this PR, I'd prefer an explicit .loadFromFs and .loadFromMemory or something API. Haven't had time to dig further into this yet though
There was a problem hiding this comment.
👍 Separate APIs really sound good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first, quick, pass for #33. It does not have docs or tests as I'd like to get some feedback on it if it's the correct approach, or if we should have different
loadmethods depending on if we want to read from fs or notFixes #33
(includes #35)