Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] [Dependency] Bumped istanbul-lib-instrument to 6.0.2 #1548

Closed
wants to merge 1 commit into from

Conversation

BboyAkers
Copy link
Contributor

What is in this PR?

Why?

This lovely library uses istanbul-lib-instrument and that packages has an earlier version of babel which has this security vulnerability.
https://security.snyk.io/vuln/SNYK-JS-BABELTRAVERSE-5962462

Updating this package after merging the above PR will solve this dependency chain vulnerability with minimal impact to end users.

Let me know if you all have any questions or if there's anything I can do to improve this PR 🙂. I'd be more than happy to!!

@bcoe
Copy link
Member

bcoe commented Feb 22, 2024

@BboyAkers anything jump out to you with regards to the AppVeyor failure?

@BboyAkers
Copy link
Contributor Author

Getting this 🤔 @bcoe

Screenshot 2024-02-22 at 9 28 16 AM

@BboyAkers
Copy link
Contributor Author

Should I upgrade node versions?

@bcoe
Copy link
Member

bcoe commented Feb 22, 2024

Should I upgrade node versions?

I'd suggest that we upgrade the Node version and switch to a GitHub action configuration similar to c8 (rather than using AppVeyor).

But, if we're updating the minimum Node.js version, we should make it a breaking change.

@BboyAkers
Copy link
Contributor Author

Should I upgrade node versions?

I'd suggest that we upgrade the Node version and switch to a GitHub action configuration similar to c8 (rather than using AppVeyor).

But, if we're updating the minimum Node.js version, we should make it a breaking change.

Gotcha and agreed! I can take a stab at upgrading the node version today and create a new PR 🙂.

@bcoe
Copy link
Member

bcoe commented Feb 26, 2024

Gotcha and agreed! I can take a stab at upgrading the node version today and create a new PR

@BboyAkers sounds good, looking forward to the PR.

Feel free to keep PMing me if I miss any updates.

@BboyAkers
Copy link
Contributor Author

BboyAkers commented Feb 27, 2024

@bcoe Been hitting a wall upgrading node #1550

@bcoe bcoe closed this Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants