Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid source-map module during signal-exit handler #1191

Merged
merged 1 commit into from
Oct 6, 2019

Conversation

coreyfarrell
Copy link
Member

Prior to this change child processes would call upon the source-map
module to remap coverage during the signal-exit handler. This was a
blocker for updating source-map to 0.7.x which uses an async
constructor method.

Now we simply save the source-map with the raw coverage data for each
file. This allows the main nyc process to perform source-map remapping.
The benefit is that the main nyc process can use async code.

Prior to this change child processes would call upon the source-map
module to remap coverage during the `signal-exit` handler.  This was a
blocker for updating `source-map` to 0.7.x which uses an async
constructor method.

Now we simply save the source-map with the raw coverage data for each
file.  This allows the main nyc process to perform source-map remapping.
The benefit is that the main nyc process can use async code.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.14% when pulling 7aacf58 on coreyfarrell:less-signal-exit into 22a5ea0 on istanbuljs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants