Address review comments..

Signed-off-by: ishan16696 <ishan.tyagi@sap.com>
ishan16696 · Feb 25, 2024 · bba77f5 · bba77f5
1 parent ea00d4f
commit bba77f5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/tx_check.go b/tx_check.go
@@ -74,7 +74,7 @@ func (tx *Tx) check(cfg checkConfig, ch chan error) {
 		}
 	} else {
 		// Check the db file starting from a specified pageId.
-		if cfg.pageId < 2 || cfg.pageId >= uint64(tx.meta.Pgid()) {
+		if cfg.pageId < 2 || cfg.pageId >= uint(tx.meta.Pgid()) {
 			ch <- fmt.Errorf("page ID (%d) out of range [%d, %d)", cfg.pageId, 2, tx.meta.Pgid())
 			return
 		}
@@ -250,20 +250,20 @@ func verifyKeyOrder(pgId common.Pgid, pageType string, index int, key []byte, pr
 
 type checkConfig struct {
 	kvStringer KVStringer
-	pageId     uint64
+	pageId     uint
 }
 
 type CheckOption func(options *checkConfig)
 
-func WithKVStringer(kvStringer KVStringer, pageID uint64) CheckOption {
+func WithKVStringer(kvStringer KVStringer, pageID uint) CheckOption {
 	return func(c *checkConfig) {
 		c.kvStringer = kvStringer
 		c.pageId = pageID
 	}
 }
 
 // WithPageId sets a page ID from which the check command starts to check
-func WithPageId(pageId uint64) CheckOption {
+func WithPageId(pageId uint) CheckOption {
 	return func(c *checkConfig) {
 		c.pageId = pageId
 	}

diff --git a/tx_check_test.go b/tx_check_test.go
@@ -35,7 +35,7 @@ func TestTx_Check_CorruptPage(t *testing.T) {
 		var cErrs []error
 
 		t.Log("Check corrupted page.")
-		errChan := tx.Check(bbolt.WithPageId(uint64(victimPageId)))
+		errChan := tx.Check(bbolt.WithPageId(uint(victimPageId)))
 		for cErr := range errChan {
 			cErrs = append(cErrs, cErr)
 		}
@@ -44,7 +44,7 @@ func TestTx_Check_CorruptPage(t *testing.T) {
 		t.Log("Check valid pages.")
 		cErrs = cErrs[:0]
 		for _, pgId := range validPageIds {
-			errChan = tx.Check(bbolt.WithPageId(uint64(pgId)))
+			errChan = tx.Check(bbolt.WithPageId(uint(pgId)))
 			for cErr := range errChan {
 				cErrs = append(cErrs, cErr)
 			}
@@ -104,7 +104,7 @@ func TestTx_Check_WithNestBucket(t *testing.T) {
 	vErr := db.View(func(tx *bbolt.Tx) error {
 		var cErrs []error
 
-		errChan := tx.Check(bbolt.WithPageId(uint64(bucketRootPageId)))
+		errChan := tx.Check(bbolt.WithPageId(uint(bucketRootPageId)))
 		for cErr := range errChan {
 			cErrs = append(cErrs, cErr)
 		}