Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance ExllamaV2Sampler with Temperature Parameter and Update EOS Token for Llama3 Compatibility #2

Conversation

ManilShrestha
Copy link

This pull request includes the following updates:

  1. Passing Temperature Parameter:
  • Updated the code to allow passing the temperature parameter through ExllamaV2Sampler.Settings(). This enhancement provides better control over the sampling process by enabling dynamic adjustment of the temperature setting.
  1. EOS Token Compatibility:
  • Modified the EOS_token handling to ensure compatibility with the Llama3 model. The previous implementation did not correctly recognize the tokenizer.eos_token_id as the EOS token in Llama3.
  • Integrated the stop_at values from the outline's extra body into the preferred_eos variable. This ensures that the end-of-sequence tokens are properly managed, accommodating both the model-specific and outline-specific stop conditions.

…OS compatible with Llama3 and 'stop_at' string from outlines
@isamu-isozaki isamu-isozaki merged commit f302126 into isamu-isozaki:dynamic_outlines Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants