Set CC and CXX environment variables using 'env' in workflows. #18425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbre
approved these changes
Sep 4, 2024
IanWood1
pushed a commit
to IanWood1/iree
that referenced
this pull request
Sep 8, 2024
…org#18425) Follow-up to iree-org#18422 (comment) and iree-org#18421 (comment). This style is more compact, but it does remove some context that could be useful - that the CC/CXX environment variables are for the build toolchain and are related to CMake and Ninja. The 'runtime' workflow is cross platform and also sets this conditionally: https://github.com/iree-org/iree/blob/1124be8025995b64804e9f02b62a0354b25dfb2b/.github/workflows/ci.yml#L112-L124 See https://github.com/iree-org/iree-template-runtime-cmake/blob/main/.github/workflows/build-and-test.yml for a more comprehensive example where we also branch on gcc and clang in the same matrix.
josemonsalve2
pushed a commit
to josemonsalve2/iree
that referenced
this pull request
Sep 14, 2024
…org#18425) Follow-up to iree-org#18422 (comment) and iree-org#18421 (comment). This style is more compact, but it does remove some context that could be useful - that the CC/CXX environment variables are for the build toolchain and are related to CMake and Ninja. The 'runtime' workflow is cross platform and also sets this conditionally: https://github.com/iree-org/iree/blob/1124be8025995b64804e9f02b62a0354b25dfb2b/.github/workflows/ci.yml#L112-L124 See https://github.com/iree-org/iree-template-runtime-cmake/blob/main/.github/workflows/build-and-test.yml for a more comprehensive example where we also branch on gcc and clang in the same matrix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #18422 (comment) and #18421 (comment).
This style is more compact, but it does remove some context that could be useful - that the CC/CXX environment variables are for the build toolchain and are related to CMake and Ninja.
The 'runtime' workflow is cross platform and also sets this conditionally:
iree/.github/workflows/ci.yml
Lines 112 to 124 in 1124be8