Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GPU] Updates mfma/wmma attribute names in the matmul test generator. #18134

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

hanhanW
Copy link
Contributor

@hanhanW hanhanW commented Aug 7, 2024

This is the follop-up for 82012e6

ef28786 only fixes the mlir files but not python test generator. The revision includes the case.

This is the follop-up for iree-org@82012e6

iree-org@ef28786
only fixes the mlir files but not python test generator. The revision
includes the case.

Signed-off-by: hanhanW <hanhan0912@gmail.com>
@hanhanW
Copy link
Contributor Author

hanhanW commented Aug 7, 2024

Hopefully this is the last one... I don't see those attributes in the grep commands.

@hanhanW hanhanW merged commit ca24b96 into iree-org:main Aug 7, 2024
44 checks passed
@hanhanW hanhanW deleted the more-fixes-for-gpu-attr-python2 branch August 7, 2024 03:28
@pashu123
Copy link
Contributor

pashu123 commented Aug 7, 2024

@hanhanW We also need to update

extract_input_type = lambda s: re.search(r"(?:MFMA|WMMA)_([^_]+)_", s).group(1)

@ScottTodd
Copy link
Member

Whoops yeah. More updates needed and the relevant test jobs didn't run on this PR. Sent #18138 so PRs like this will run the tests in the future.

hanhanW added a commit to hanhanW/iree that referenced this pull request Aug 7, 2024
It is a follow-up for iree-org#18134 (comment)

Signed-off-by: hanhanW <hanhan0912@gmail.com>
ScottTodd added a commit that referenced this pull request Aug 7, 2024
Would have been nice to run tests on
#18134, without needing to use the
`ci-extra` git trailer.
hanhanW added a commit to hanhanW/iree that referenced this pull request Aug 7, 2024
It is a follow-up for iree-org#18134 (comment)

Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW added a commit that referenced this pull request Aug 7, 2024
…8140)

It is a follow-up for
#18134 (comment)

ci-extra:
build_packages,test_amd_mi250,test_amd_mi300,test_amd_w7900,test_nvidia_t4

---------

Signed-off-by: hanhanW <hanhan0912@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants