-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename long-running to large in benchmark suite and workflows #13914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzread
force-pushed
the
bench-rename-long
branch
2 times, most recently
from
June 2, 2023 06:27
8e787be
to
139bbb8
Compare
This reverts commit 57e7d1c.
pzread
changed the title
Rename long-running to large
Rename long-running to large in benchmark suite and workflows
Jun 2, 2023
pzread
requested review from
GMNGeoffrey,
ScottTodd and
antiagainst
as code owners
June 2, 2023 18:23
pzread
added
the
benchmarks:comp-stats
Run default compilation statistics benchmarks
label
Jun 2, 2023
GMNGeoffrey
approved these changes
Jun 5, 2023
pzread
added
benchmarks:cuda
Run default CUDA benchmarks
benchmarks:x86_64
Run default x86_64 benchmarks
and removed
benchmarks:comp-stats
Run default compilation statistics benchmarks
labels
Jun 5, 2023
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
…rg#13914) Rename "long-running" and "*-long" to "large" in the benchmark suite and workflows.
nhasabni
pushed a commit
to plaidml/iree
that referenced
this pull request
Aug 24, 2023
…rg#13914) Rename "long-running" and "*-long" to "large" in the benchmark suite and workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename "long-running" and "*-long" to "large" in the benchmark suite and workflows.
As the suggestion in #13129 (and after talked to @mariecwhite), "large" seems to be a more suitable name for the current large benchmarks in the benchmark suite.
Test with different presets: https://github.com/openxla/iree/actions/runs/5157469120 (passed)
Test with large (long-running) workflow: https://github.com/openxla/iree/actions/runs/5157469106 (passed)