Fix compatibility with tornado 6.2 beta #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minrk
changed the title
rather than rely on deprecated IOLoop(make_current=False) AsyncIOLoop is explicit about owning its own loop, without making it 'current'
|
We have an explicit job that tests prereleases, and it has been failing since the new tornado beta came out. The intent was to contain the failure to one job. |
|
Good plan! I'll rebase to just the fix tomorrow, unless you want to do it first. |
blink1073
reviewed
Jun 14, 2022
blink1073
changed the title
blink1073
changed the title
This was referenced Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect this will reveal failures with the latest tornado 6.2 beta, which is mainly an update to try to deal with asyncio getting rid of the notion of a 'current' event loop that's not running.