Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use message queue for abort_queues #853

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Conversation

minrk
Copy link
Member

@minrk minrk commented Feb 3, 2022

ensures queued messages are aborted, rather than racing with coroutine processing which would complete too soon during asynchronous executions.

Discovered in ipython/ipyparallel#663 where making do_execute return a Future would cause abort tests to fail.

ensures queued messages are aborted,
rather than racing with coroutine processing,
which would complete too soon during asynchronous executions
@blink1073
Copy link
Contributor

This test has failed twice in a row, seems relevant:

FAILED work/ipykernel/ipykernel/test_venv/lib/python3.9/site-packages/jupyter_client/tests/test_kernelmanager.py::TestParallel::test_start_parallel_process_kernels[tcp]

@minrk
Copy link
Member Author

minrk commented Feb 4, 2022

Re-ran the tests and they passed. I don't really see how it could have affected that test.

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants