Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add usage_request and usage_reply based on psutil #805

Merged
merged 8 commits into from
Jan 11, 2022
Merged

Add usage_request and usage_reply based on psutil #805

merged 8 commits into from
Jan 11, 2022

Conversation

echarles
Copy link
Member

This PR aims to start a discussion to add a new message type usage_request/usage_reply as discussed in the last JupyterLab meeting jupyterlab/frontends-team-compass#128 (comment)

On JupyterLab jupyterlab/jupyterlab#11285 is needed.

cc/ @Carreau

@echarles echarles mentioned this pull request Nov 21, 2021
Closed
mlucool
mlucool reviewed Nov 21, 2021
View reviewed changes
ipykernel/kernelbase.py Outdated Show resolved Hide resolved
mlucool
mlucool reviewed Nov 21, 2021
View reviewed changes
ipykernel/kernelbase.py Outdated Show resolved Hide resolved
ipykernel/kernelbase.py Outdated Show resolved Hide resolved
@echarles
Copy link
Member Author

A JupyterLab extension example/experiment using this features is available on https://github.com/datalayer-experiments/jupyter-usage

@echarles echarles marked this pull request as ready for review December 3, 2021 16:48
@echarles
Copy link
Member Author

echarles commented Dec 3, 2021

@Carreau This is ready for review

@Carreau Carreau self-requested a review December 10, 2021 16:40
Carreau
Carreau reviewed Jan 6, 2022
View reviewed changes
ipykernel/kernelbase.py Outdated Show resolved Hide resolved
Carreau
Carreau reviewed Jan 6, 2022
View reviewed changes
ipykernel/kernelbase.py Outdated Show resolved Hide resolved
@echarles echarles mentioned this pull request Jan 7, 2022
Open
@Carreau
Copy link
Member

Carreau commented Jan 7, 2022

Rebased on master to see if it fixes the test failures. Those should have been fixed on main branch.

@Carreau Carreau merged commit 0ab288f into ipython:main Jan 11, 2022
@echarles
Copy link
Member Author

Super! Thx @Carreau

@jasongrout
Copy link
Member

For clarification, for those reading this, usage_request and usage_reply are non-standard kernel messages right now (i.e., they are not in the kernel message spec, so they are specific implementation details of ipykernel).

@jasongrout
Copy link
Member

The related JupyterLab PR, jupyterlab/jupyterlab#11285, is now closed:

I will close this one as we are not going to go further with this specific implementation. A potential more generic follow-up can be discussed in jupyterlab/jupyterlab#12117

If this message is not going to be used, should we revert this PR? @echarles?

@echarles
Copy link
Member Author

The usage request/reply is consumed by https://github.com/Quansight/jupyterlab-kernel-usage

@Zsailer Zsailer mentioned this pull request Feb 24, 2022
Closed
@echarles echarles mentioned this pull request Apr 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau left review comments

@mlucool mlucool mlucool left review comments

@JohanMabille JohanMabille JohanMabille left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@echarles @Carreau @jasongrout @mlucool @JohanMabille