PR: Handle system commands that use UNC paths on Windows #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blink1073, could you help us to review and merge this one? Our users are having troubles with UNC paths on Windows and @dalthviz tracked the problem to By the way, @dalthviz had to skip |
|
Released as 5.2.1. |
|
Thanks a lot for lighting fast response @blink1073! |
|
No problem, good to see you @ccordoba12! |
|
Nice to see you too around @blink1073! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an implementation of
system_pipedinZMQInteractiveShellthat handles UNC paths on Windows.Fixes spyder-ide/spyder#10762
The failing test in Travis (
test_complete) seems unrelated to this.