Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands Refactor Part 1 #262

Merged
merged 66 commits into from
Nov 4, 2014
Merged

Commands Refactor Part 1 #262

merged 66 commits into from
Nov 4, 2014

Commits on Nov 4, 2014

  1. commands: Made Response#Error return an *Error instead of an error

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    19e5fba View commit details
    Browse the repository at this point in the history

  2. commands: Removed unused output stream field from Response

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    94683bb View commit details
    Browse the repository at this point in the history

  3. commands: Made Response implement io.Reader

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    3cebd21 View commit details
    Browse the repository at this point in the history

  4. commands: Simplified Error string output

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    e8b37ac View commit details
    Browse the repository at this point in the history

  5. commands: Added Request#Options so consumers can iterate through prov… 

    …ided options
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    a65c99e View commit details
    Browse the repository at this point in the history

  6. commands/http: Moved HTTP RPC into commands/http package

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    8b61daa View commit details
    Browse the repository at this point in the history

  7. commands/http: Moved HTTP RPC handler into commands/http

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    43c61a4 View commit details
    Browse the repository at this point in the history

  8. commands: Silently skip unrecognized options, it should be up to the … 

    …transport to decide if they cause an error
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    53e1359 View commit details
    Browse the repository at this point in the history

  9. commands: Fixed test

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    b033e33 View commit details
    Browse the repository at this point in the history

  10. commands: Added Context() to Request

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    20f86c0 View commit details
    Browse the repository at this point in the history

  11. commands/http: Made client load RPC host from config

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    48bd73c View commit details
    Browse the repository at this point in the history

  12. commands: Added Request#SetContext()

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    289bce6 View commit details
    Browse the repository at this point in the history

  13. commands/http: Made Handler set request contexts

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    29b96b6 View commit details
    Browse the repository at this point in the history

  14. commands/http: Moved http request parsing into a Parse function

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    52bc8bd View commit details
    Browse the repository at this point in the history

  15. commands/http: Parse command args

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    7531625 View commit details
    Browse the repository at this point in the history

  16. commands/http: Send request arguments in client requests

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    42633e5 View commit details
    Browse the repository at this point in the history

  17. commands/http: Use request body as command input stream

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    507192e View commit details
    Browse the repository at this point in the history

  18. commands: Gave Requests a reference to the command they are being cal… 

    …led on
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    81f2925 View commit details
    Browse the repository at this point in the history

  19. commands: Added a Format function to Command, for creating human-read… 

    …able output based on a Response
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    38f8f1c View commit details
    Browse the repository at this point in the history

  20. commands: Added plaintext marshalling to Response#Marshal()

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    b54801c View commit details
    Browse the repository at this point in the history

  21. commands/http: Explicitly define the MIME types for each encoding

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    714e13b View commit details
    Browse the repository at this point in the history

  22. commands/http: Don't try to parse HTTP response into a Response, just… 

    … read the output
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    32a2959 View commit details
    Browse the repository at this point in the history

  23. commands: Fixed tests

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    6302356 View commit details
    Browse the repository at this point in the history

  24. commands: Added a Type field for defining output struct formats

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    ef290fa View commit details
    Browse the repository at this point in the history

  25. commands/http: Made HTTP client unmarshal response values based on th… 

    …e Command#Type
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    c0a9871 View commit details
    Browse the repository at this point in the history

  26. fix(cmd/ipfs2, commands) imports

    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    b1bf60b View commit details
    Browse the repository at this point in the history

  27. refactor(commands) swap argument order to match Http(w, r) idiom

    @jbenet
    Brian Tiger Chow authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    4911dc0 View commit details
    Browse the repository at this point in the history

  28. commands: Don't error when marshalling empty Responses

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    b61cfd9 View commit details
    Browse the repository at this point in the history

  29. commands: Added 'Private' field to Command

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    460387f View commit details
    Browse the repository at this point in the history

  30. commands/http: Pass root command in as field instead of statically de… 

    …pending on core/commands
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    1e0cabd View commit details
    Browse the repository at this point in the history

  31. commands/http: 404 when trying to call root command

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    ea09268 View commit details
    Browse the repository at this point in the history

  32. commands/http: Improved client error handling

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    abcebb0 View commit details
    Browse the repository at this point in the history

  33. commands/http: Error if trying to run private command

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    cfa56dd View commit details
    Browse the repository at this point in the history

  34. commands/cli: Made Parse handle multiple root commands

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    c0d3edd View commit details
    Browse the repository at this point in the history

  35. commands: Removed Command#Private field

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    83b2ba0 View commit details
    Browse the repository at this point in the history

  36. commands/cli: Error if no subcommand matched

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    30e9687 View commit details
    Browse the repository at this point in the history

  37. commands: Changed Request arguments to a []interface{}

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    827f1dd View commit details
    Browse the repository at this point in the history

  38. commands: Removed inpout stream from Request

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    3a8d60c View commit details
    Browse the repository at this point in the history

  39. commands: Fixed tests

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    39c78fb View commit details
    Browse the repository at this point in the history

  40. commands/http: Added stream argument handling to client and request p… 

    …arser
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    40858b4 View commit details
    Browse the repository at this point in the history

  41. commands: Renamed ArgPath to ArgFile

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    f7aa2b9 View commit details
    Browse the repository at this point in the history

  42. commands/cli: Open argument files when creating Requests (Moved out o… 

    …f HTTP client)
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    ee2c769 View commit details
    Browse the repository at this point in the history

  43. commands: Check argument validity when running commands

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    e8d0cbf View commit details
    Browse the repository at this point in the history

  44. commands/cli: Made parser handle variadic arguments

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    2c8fc85 View commit details
    Browse the repository at this point in the history

  45. commands/http: Made parser/client handle variadic arguments

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    405cfd9 View commit details
    Browse the repository at this point in the history

  46. commands: Fixed Request#CheckArguments not erroring when required arg… 

    …uments were missing
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    586a019 View commit details
    Browse the repository at this point in the history

  47. commands: CLI Parse: Don't parse args until after creating request

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    dbeffb6 View commit details
    Browse the repository at this point in the history

  48. commands: Moved argument checking into a Command method, fail early w… 

    …hen parsing commands
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    75649f3 View commit details
    Browse the repository at this point in the history

  49. commands: Renamed Response#Value to Response#Output

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    69a56de View commit details
    Browse the repository at this point in the history

  50. commands: Return a reader in a Response#Reader method, instead of mak… 

    …ing Response implementing io.Reader
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    f6c3888 View commit details
    Browse the repository at this point in the history

  51. commands: Cleaned up argument validation

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    bc6938d View commit details
    Browse the repository at this point in the history

  52. commands/http: Ensure request URLs start with expected prefix

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    446acdc View commit details
    Browse the repository at this point in the history

  53. commands/http: Respond with error if encoding option isn't a string

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    4552fce View commit details
    Browse the repository at this point in the history

  54. commands/http: Unexported Handler fields and created constructor

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    f76048f View commit details
    Browse the repository at this point in the history

  55. commands: Nicer syntax for Argument definition

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    958e524 View commit details
    Browse the repository at this point in the history

  56. commands/cli: Better comment for parsePath

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    068e10c View commit details
    Browse the repository at this point in the history

  57. commands: Replaced 'Formatter' with 'Marshaller'

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    0149f65 View commit details
    Browse the repository at this point in the history

  58. commands: Safer type coercion when choosing marshaller

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    33ad56e View commit details
    Browse the repository at this point in the history

  59. commands: Allow overriding marshaller for any encoding type

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    2a1116c View commit details
    Browse the repository at this point in the history

  60. commands/http: Refactored API to a Client object that takes a string … 

    …address
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    5e5d534 View commit details
    Browse the repository at this point in the history

  61. commands/http: Cleaner URL formation in client

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    33b0990 View commit details
    Browse the repository at this point in the history

  62. commands/http: Use net/url querystring encoder

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    e57cd9b View commit details
    Browse the repository at this point in the history

  63. commands/http: Decomposed Client#Send function

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    c8ae4b6 View commit details
    Browse the repository at this point in the history

  64. commands/http: Renamed variable for clarity

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    df6c700 View commit details
    Browse the repository at this point in the history

  65. commands: Fixed panic when trying to marshal without a command set in… 

    … request
    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    db9c7f7 View commit details
    Browse the repository at this point in the history

  66. commands/http: Cleaned up argument handling in Parse

    @mappum @jbenet
    mappum authored and jbenet committed Nov 4, 2014
    Configuration menu
    Copy the full SHA
    1b9b603 View commit details
    Browse the repository at this point in the history