Commands Refactor Part 1 #262

jbenet · 2014-11-04T09:53:15Z

We split #196 in two parts. this is the first. it only has the commands/ directory.

jbenet · 2014-11-04T09:56:43Z

@maybebtc can you look this over and confirm?

You may want to pull down both cmd-ref-part1 and cmd-ref-part2 and verify changes against commands-refactor.

…ided options

…transport to decide if they cause an error

…led on

…able output based on a Response

… read the output

…e Command#Type

…hen parsing commands

…ing Response implementing io.Reader

…address

… request

jbenet · 2014-11-04T10:06:11Z

@maybebtc nvm. i rebased on top of master, so now things will be different.

leeroy jenkins.

Commands Refactor Part 1

btc · 2014-11-04T10:23:04Z

I found one instance of casting I wanted to address. Addressed in a branch of miscellaneous changes. Can merge later.

5216bf1
https://github.com/jbenet/go-ipfs/tree/maybebtc-november

jbenet · 2014-11-04T10:27:22Z

@maybebtc add it to cmd-ref-part2

btc · 2014-11-04T10:46:31Z

done

976a7c1
d1405e4

dial queue: fix possible goroutine leak

jbenet added the status/in-progress In progress label Nov 4, 2014

This was referenced Nov 4, 2014

Commands Refactor Part 2 #263

Closed

Refactoring Commands #196

Closed

mappum and others added 26 commits November 4, 2014 02:04

commands: Made Response#Error return an *Error instead of an error

19e5fba

commands: Removed unused output stream field from Response

94683bb

commands: Made Response implement io.Reader

3cebd21

commands: Simplified Error string output

e8b37ac

commands: Added Request#Options so consumers can iterate through prov…

a65c99e

…ided options

commands/http: Moved HTTP RPC into commands/http package

8b61daa

commands/http: Moved HTTP RPC handler into commands/http

43c61a4

commands: Silently skip unrecognized options, it should be up to the …

53e1359

…transport to decide if they cause an error

commands: Fixed test

b033e33

commands: Added Context() to Request

20f86c0

commands/http: Made client load RPC host from config

48bd73c

commands: Added Request#SetContext()

289bce6

commands/http: Made Handler set request contexts

29b96b6

commands/http: Moved http request parsing into a Parse function

52bc8bd

commands/http: Parse command args

7531625

commands/http: Send request arguments in client requests

42633e5

commands/http: Use request body as command input stream

507192e

commands: Gave Requests a reference to the command they are being cal…

81f2925

…led on

commands: Added a Format function to Command, for creating human-read…

38f8f1c

…able output based on a Response

commands: Added plaintext marshalling to Response#Marshal()

b54801c

commands/http: Explicitly define the MIME types for each encoding

714e13b

commands/http: Don't try to parse HTTP response into a Response, just…

32a2959

… read the output

commands: Fixed tests

6302356

commands: Added a Type field for defining output struct formats

ef290fa

commands/http: Made HTTP client unmarshal response values based on th…

c0a9871

…e Command#Type

fix(cmd/ipfs2, commands) imports

b1bf60b

mappum added 19 commits November 4, 2014 02:04

commands: Moved argument checking into a Command method, fail early w…

75649f3

…hen parsing commands

commands: Renamed Response#Value to Response#Output

69a56de

commands: Return a reader in a Response#Reader method, instead of mak…

f6c3888

…ing Response implementing io.Reader

commands: Cleaned up argument validation

bc6938d

commands/http: Ensure request URLs start with expected prefix

446acdc

commands/http: Respond with error if encoding option isn't a string

4552fce

commands/http: Unexported Handler fields and created constructor

f76048f

commands: Nicer syntax for Argument definition

958e524

commands/cli: Better comment for parsePath

068e10c

commands: Replaced 'Formatter' with 'Marshaller'

0149f65

commands: Safer type coercion when choosing marshaller

33ad56e

commands: Allow overriding marshaller for any encoding type

2a1116c

commands/http: Refactored API to a Client object that takes a string …

5e5d534

…address

commands/http: Cleaner URL formation in client

33b0990

commands/http: Use net/url querystring encoder

e57cd9b

commands/http: Decomposed Client#Send function

c8ae4b6

commands/http: Renamed variable for clarity

df6c700

commands: Fixed panic when trying to marshal without a command set in…

db9c7f7

… request

commands/http: Cleaned up argument handling in Parse

1b9b603

jbenet force-pushed the cmd-ref-part1 branch from 1208ad8 to 1b9b603 Compare November 4, 2014 10:05

jbenet added a commit that referenced this pull request Nov 4, 2014

Merge pull request #262 from jbenet/cmd-ref-part1

b1958be

Commands Refactor Part 1

jbenet merged commit b1958be into master Nov 4, 2014

jbenet deleted the cmd-ref-part1 branch November 4, 2014 10:06

jbenet removed the status/in-progress In progress label Nov 4, 2014

jbenet mentioned this pull request Nov 4, 2014

Make webui skeleton #226

Closed

ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021

Merge pull request ipfs#262 from raulk/fix/dialqueue-enqchan

5f67727

dial queue: fix possible goroutine leak

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commands Refactor Part 1 #262

Commands Refactor Part 1 #262

jbenet commented Nov 4, 2014

jbenet commented Nov 4, 2014

jbenet commented Nov 4, 2014

btc commented Nov 4, 2014

jbenet commented Nov 4, 2014

btc commented Nov 4, 2014

Commands Refactor Part 1 #262

Commands Refactor Part 1 #262

Conversation

jbenet commented Nov 4, 2014

jbenet commented Nov 4, 2014

jbenet commented Nov 4, 2014

btc commented Nov 4, 2014

jbenet commented Nov 4, 2014

btc commented Nov 4, 2014